-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Multi step lattice dynamics workflow using hiPhive #559
base: main
Are you sure you want to change the base?
Changes from 19 commits
43dae04
c163fac
4424f40
8a08ab9
1421e04
d15921b
dcfda62
d5ad270
b635753
c16e280
3df39f5
065d908
968f359
4ec85ce
ef0638e
ca44a18
51a790f
c8e1a51
627654a
f30d29c
365775f
113e970
b055aad
adfd241
9f61b69
2a4c89c
4c7c26c
13edc4c
82c1b94
a330832
3577e6e
5d46f41
cff4cbf
73e84af
41679a0
28b31ac
c7b2273
816d911
12073e3
1f41a93
10bfc7b
5655a49
dfcc83a
7c45eba
e10f4b1
3927b38
2d4b42a
402e1ce
d8037ff
b6a571f
fd279ff
b6f8d7c
dfb4f7c
b83853a
ce9db37
fa87a92
c20b11d
f8b37ab
c3ff2e6
94226f3
84bdd02
bf0002f
17b6b42
2b875e4
9c0886e
7e84f7c
763348e
69d0dc7
54ee859
6466bb9
8edb536
884d84f
030fbd0
ba5e108
8505caa
7f31016
a5f295a
c773efc
3837694
59b6b80
72c4986
de363c4
511253e
3e0c570
11cfc5e
30940f5
90f7fb1
cfda488
6e389c9
111c770
ca47cbf
f0ff47c
7111126
31e9def
3b93a06
4851a45
3c877d9
8c20724
f731419
3b49eb3
a077560
11c7ff1
bad7f5e
c45b616
7250e2a
82ef1c0
8889d3e
6e9da67
c18fe93
60e9a7b
300da7b
4f7c264
5283d9e
2fb63c2
a249cb8
d5090fb
49ae442
8b0019d
8144b7b
5239a79
e06dd99
4e90106
228641a
4aca655
092baf5
edf646b
ed0458f
c9a9b62
522b593
675db1f
1132bbc
0e3f11f
848633a
bf6c01c
86fa57e
f788405
20ecb5d
7571fad
d17f1c3
a88147b
1a4ff45
8d80ab9
1096e99
027ef9b
bf9d481
5f87e84
26221c9
c2ee042
0cc0627
eb0a801
1a2cf21
623201a
9fbd3d1
f95073c
faefc1e
ee70772
f267351
fcd1f4d
a93b1ab
0cfbd60
697d1d8
c263f2a
a019641
81f5841
ed274ab
d2fe199
56185f6
5296606
dc4eaf0
d474d21
7a9e856
0c4da0a
f5498c5
c3150fa
5f6abad
d53beab
6d3754d
4b2d62f
11ac2fc
69f4ff5
d2e483e
36b7977
3db684d
55aceb8
7b986d6
7f474a3
25f931e
9706bd8
87d8c32
f34d369
13e731a
ff770f3
9770434
2b95bd0
738d825
3d5d4dc
1f638c6
a0d76b6
b1e5dd7
2f6f9f1
319cfc6
3991202
5515d1a
e957c61
4593415
5c9e168
b1f93de
4bcd97e
a41d31e
a0d2050
f1217b6
2790070
58aedd1
f92a7a4
7befb93
06b2a3a
c61dcf7
dbbfa40
af590ba
20ad5c3
bbebbd4
5f977f0
02ff2cc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -246,7 +246,8 @@ def generate_frequencies_eigenvectors( | |
) | ||
|
||
|
||
@job(data=["forces", "displaced_structures"]) | ||
# @job(data=["forces", "displaced_structures"]) | ||
@job | ||
def run_phonon_displacements( | ||
displacements, | ||
structure: Structure, | ||
|
@@ -279,6 +280,7 @@ def run_phonon_displacements( | |
"forces": [], | ||
"uuids": [], | ||
"dirs": [], | ||
"structure": [] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Pay attention if your changes are likely to break another workflow, such as There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just to mention this: for large structures, this needs to be in the document store then. (E.g., you could use a forcefield to run a common version of your workflow with a larger structure) I made this experience with the phonon workflow before. |
||
} | ||
|
||
for i, displacement in enumerate(displacements): | ||
|
@@ -306,6 +308,9 @@ def run_phonon_displacements( | |
outputs["uuids"].append(phonon_job.output.uuid) | ||
outputs["dirs"].append(phonon_job.output.dir_name) | ||
outputs["forces"].append(phonon_job.output.output.forces) | ||
outputs["structure"].append(phonon_job.output.output.structure) | ||
# outputs["forces"].append(phonon_job.output.output.output.forces) | ||
# outputs["structure"].append(phonon_job.output.output.output.structure) | ||
|
||
displacement_flow = Flow(phonon_jobs, outputs) | ||
return Response(replace=displacement_flow) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a reminder: this is really important for large structures. Just saw this change by chance.