[WIP] Defects CP2K #280
Open
[WIP] Defects CP2K #280
+2,233
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto cp2k-defects
I cannot for the life of me figure out why using the combined parent breaks everything, but I guess the multiple_input_updator can only go one level deep for inheriting
I'll look for a way to clean this up later
# Conflicts: # src/atomate2/cp2k/flows/core.py
# Conflicts: # src/atomate2/cp2k/schemas/task.py
|
Hi @nwinner, the flow is already in common. The parts that should be language agnostic have been left as abstract methods. I also added a tutorial on dealing with DFT-code agnostic workflows here: Maybe you can just do a PR for driving the CP2K defect calculations only and we can figure out the schema later after a bit of discussion. In short, I really think the workflow should only take you as far as the DefectEntry creation and Freysoldt correction. The final chempot stuff should be left to builders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for my defects module.
The jobs/flows could be deleted if @jmmshn 's module moves into common. The builder for assimilating after the fact could be adjusted and added to common as well. To my knowledge there is no equivalent in VASP module. Its not totally code agnostic at the moment though.