[WIP] Added waveder support #187
Draft
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 76.90% 76.57% -0.33%
==========================================
Files 62 62
Lines 5317 5328 +11
Branches 755 757 +2
==========================================
- Hits 4089 4080 -9
- Misses 1020 1040 +20
Partials 208 208
|
|
Hi Jimmy, sorry I didn't get back to you about this PR. I think spoofing something very small in the optics directory would be great. |
utf
reviewed
Mar 11, 2023
| """ | ||
| try: | ||
| return Waveder.from_binary(dir_name / "WAVEDER") | ||
| except Exception: |
|
Hi @jmmshn, what's the status of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to store Wavder objects in pymatgen
The
Wavderobject is helpful for a host of optical analysis functions so I'm trying to figure out how to store it properly.I'm of the opinion that by default people will not want to use it for general optical workflows but will like to have it for special cases.
@utf Do you have any opinion on how test files should be added?
These files are quite large so I was thinking about spoofing something in the current optics test folders.