[WIP] Fix bump phonopy #1006
Draft
[WIP] Fix bump phonopy #1006
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JaGeo , I had a look at the phonopy source code changes between v2.28 and v.2.27, I could not really pinpoint what is causing the issue with different values of the average Gruneisen parameter here. I guess it has something to do with following PR. But am not sure about it |
|
How large are the changes? Could you give more details? Thanks! |
|
The average Gruneisen value now comes out to be |
|
Yeah, I think we need a bit more analysis here. This is quite a large change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update phonopy version
Todo