Fixing version instance class generation #17
Conversation
|
Also, the form is broken, even the live version. The instance class field won't show up unless 14.6 or lower is selected. Edit: fixed with latest commit |
This module has to be built with the script, pg has a lot of version/instance size specifics that are built. I would approve PR #15 which addresses this. There is a merge conflict though because the YAml changes merged last week. Whole YAML file is managed via the build script. I'll rebase and push again on #15 |
| @@ -185,7 +185,7 @@ def transform_instance_class_from(t, from) | |||
| "properties" => { | |||
| "version" => {"const" => version}, | |||
| "instance_class" => { | |||
| "$ref" => ref_name | |||
| $ref => ref_name | |||
There was a problem hiding this comment.
$ref is a valid variable declaration in ruby, this will produce strange behavior, I assume it'll merge over the value on the key nil which is what $ref will evaluate to.
Getting this error and not sure why: Fragment refs not supported
Also, updated the sort for update-instance-classes.rb to build the params $defs because i was getting the error
comparison of Hash with Has failed. this was a messy workaround to get the instance classes to generate, though i had to manually modify the massdriver.yaml after to clean up a little.