-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add kulala-ls #7477
base: main
Are you sure you want to change the base?
feat: add kulala-ls #7477
Conversation
e4286af
to
87a7a61
Compare
Closes williamboman/mason.nvim#1806 |
Maybe you may want to use kulala-ls@latest, instead of the fixed version, because I plan to add a lot of features to it in the upcoming days 👍🏾🤞🏾 /Edit Nvm, it was me not knowing about the used tooling:
|
@gorillamoe Do you have any idea why lspconfig is using the current working directory as root when searching for the kulala-ls binary, instead of using mason's |
Have to check, I'm not using mason, so it's always a bit of work to set this up for debugging. |
Okay I checked, the ---
name: kulala_ls
description: A minimal language server for HTTP syntax
homepage: https://github.com/mistweaverco/kulala-ls
licenses: [MIT]
languages: [http]
categories: [LSP]
source:
id: pkg:npm/@mistweaverco/[email protected]
bin:
kulala-ls: npm:kulala-ls Note the bin changed, because the binary itself is I'm not sure this is how it is supposed to do, but all other lspconfigs are also with a underscore, so I just went with it. TBH, I think it's confusing, but this should do the trick, yes? 🤔 |
@gorillamoe Nice, that seems to work. Thank you! |
Co-authored-by: @gorillamoe
support 😄 |
Describe your changes
Issue ticket number and link
Checklist before requesting a review
I haven't gotten kulala-ls to attach properly. It seems to be using the current working directory as root when searching for the binary instead of
~/.local/share/nvim/mason/bin/
. Is that an issue with my PR or an issue with nvim-lspconfig?Screenshots