Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add kulala-ls #7477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add kulala-ls #7477

wants to merge 1 commit into from

Conversation

mawkler
Copy link

@mawkler mawkler commented Oct 8, 2024

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have successfully tested installation of the package.
  • I have successfully tested the package after installation.

I haven't gotten kulala-ls to attach properly. It seems to be using the current working directory as root when searching for the binary instead of ~/.local/share/nvim/mason/bin/. Is that an issue with my PR or an issue with nvim-lspconfig?

Screenshots

@williambotman williambotman requested a review from a team October 8, 2024 13:03
@mawkler mawkler force-pushed the main branch 2 times, most recently from e4286af to 87a7a61 Compare October 8, 2024 13:05
@mawkler
Copy link
Author

mawkler commented Oct 9, 2024

Closes williamboman/mason.nvim#1806

@gorillamoe
Copy link

gorillamoe commented Oct 9, 2024

Maybe you may want to use kulala-ls@latest, instead of the fixed version, because I plan to add a lot of features to it in the upcoming days 👍🏾🤞🏾

/Edit

Nvm, it was me not knowing about the used tooling:

Note: By default, Renovate is configured to look for new releases for pkg:github sources.

@mawkler
Copy link
Author

mawkler commented Oct 10, 2024

@gorillamoe Do you have any idea why lspconfig is using the current working directory as root when searching for the kulala-ls binary, instead of using mason's bin/ directory?

@gorillamoe
Copy link

Have to check, I'm not using mason, so it's always a bit of work to set this up for debugging.

@gorillamoe
Copy link

Okay I checked, the package.yaml should look like this I guess:

---
name: kulala_ls
description: A minimal language server for HTTP syntax
homepage: https://github.com/mistweaverco/kulala-ls
licenses: [MIT]
languages: [http]
categories: [LSP]

source:
  id: pkg:npm/@mistweaverco/[email protected]

bin:
  kulala-ls: npm:kulala-ls

Note the bin changed, because the binary itself is kulala-ls, but the lsp config is called kulala_ls.

I'm not sure this is how it is supposed to do, but all other lspconfigs are also with a underscore, so I just went with it.

TBH, I think it's confusing, but this should do the trick, yes? 🤔

@mawkler
Copy link
Author

mawkler commented Oct 10, 2024

@gorillamoe Nice, that seems to work. Thank you!

@iamxiaojianzheng
Copy link

support 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants