Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release improvements #640

Draft
wants to merge 97 commits into
base: main
Choose a base branch
from

Commits on Dec 2, 2024

  1. Upgrade danger from 3.18.0 to 3.20.2.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e5dfb03 View commit details
    Browse the repository at this point in the history
  2. Use /bin/bash instead of bash from the $PATH to keep things con…

    …sistent with the shebangs that are used throughout.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3e421d3 View commit details
    Browse the repository at this point in the history
  3. event.json has placeholder values, and incorrect & inconsistent ver…

    …sion values.
    
    It only seems to be used for testing with `act`. `event.json` should either be generated or be manually created; in either case, it should reside somewhere that is ignored by git, as the only source of version info in git should be version tags.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    47336b7 View commit details
    Browse the repository at this point in the history
  4. mise is installed via brew bundle.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    abc9dab View commit details
    Browse the repository at this point in the history
  5. clean seems unnecessary in bootstrap.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    85be608 View commit details
    Browse the repository at this point in the history
  6. Remove unused $echo variable.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8778af7 View commit details
    Browse the repository at this point in the history
  7. Remove seemingly unnecessary pushd & popd.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    eb8ee0e View commit details
    Browse the repository at this point in the history
  8. Output error to stderr instead of stdout.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    004b108 View commit details
    Browse the repository at this point in the history
  9. Makefile: Mirror bash by using ${…} & $(…) for all variables & co…

    …mmand substitutions, respectively.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    92ac725 View commit details
    Browse the repository at this point in the history
  10. script/bottle: reword "better" as "newer".

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    d0422f4 View commit details
    Browse the repository at this point in the history
  11. Upgrade Xcode dependency to 14.2.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    477925c View commit details
    Browse the repository at this point in the history
  12. Obtain path to tap via brew --repo mas-cli/tap instead of hardcodin…

    …g it.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    a643ee6 View commit details
    Browse the repository at this point in the history
  13. release.yml: remove unnecessary output.

    Remove commented code.
    
    Improve step name.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8d0e92b View commit details
    Browse the repository at this point in the history
  14. release.yml: Check pre_release once for all of homebrew-core jo…

    …b instead of once per each step of that job.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    d5a0b42 View commit details
    Browse the repository at this point in the history
  15. Improve script/lint output.

    Change YAML emoji to fix spacing issue.
    
    Move YAML lint before Git lint to keep the names getting progressively shorter.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    790c2f3 View commit details
    Browse the repository at this point in the history
  16. Simplify script/bootstrap.

    We shouldn't need to delete `Brewfile.lock.json` because it doesn't actually lock anything; it just records versions that were installed.
    
    If we don't delete it, new `brew bundle install` run just adds info about what was installed during its run to the existing info about previous bundle installs.
    
    By not deleting, the code can be simplified as per this commit.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f6966d3 View commit details
    Browse the repository at this point in the history
  17. Install tools via Homebrew instead of via mise.

    Remove mise.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ce511b2 View commit details
    Browse the repository at this point in the history
  18. Fix typo.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    79e280e View commit details
    Browse the repository at this point in the history
  19. If a bottle & its checksum are the same for multiple versions of the …

    …same OS, then a checksum is required only for the oldest OS version that shares that bottle/checksum; all later versions of the OS will use that checksum.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    410bc6b View commit details
    Browse the repository at this point in the history
  20. Update Homebrew formula URL.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5a1fe1f View commit details
    Browse the repository at this point in the history
  21. Update script usage output.

    Fix acceptable argument count.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    a8ac72b View commit details
    Browse the repository at this point in the history
  22. Use short/abbreviated options for consistency.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ff58b8b View commit details
    Browse the repository at this point in the history
  23. Use double quotes around bash substitutions.

    Use braces around bash variable uses.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b57e4e2 View commit details
    Browse the repository at this point in the history
  24. Simplify defaults for unsupplied script arguments.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    8252f69 View commit details
    Browse the repository at this point in the history
  25. Replace bash test with [[ ]].

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    66ebc0f View commit details
    Browse the repository at this point in the history
  26. cd into root of mas project at beginning of every bash script.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    87cc550 View commit details
    Browse the repository at this point in the history
  27. Ensure single newline at end of every file.

    Ensure no newlines at beginning of any file.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    482bad4 View commit details
    Browse the repository at this point in the history
  28. Delete unnecessary bash comment.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    099bd8a View commit details
    Browse the repository at this point in the history
  29. Use bash '…', $'…', or unquoted word instead of "…" whenever po…

    …ssible.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b86314e View commit details
    Browse the repository at this point in the history
  30. Move bash variable to left of test.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3b2ea95 View commit details
    Browse the repository at this point in the history
  31. Inline bash variables.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    4e2827d View commit details
    Browse the repository at this point in the history
  32. Write to stderr where appropriate.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7efdb59 View commit details
    Browse the repository at this point in the history
  33. Simplify script/update_headers.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c416196 View commit details
    Browse the repository at this point in the history
  34. Suppress output for class-dump executable check.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3d393c8 View commit details
    Browse the repository at this point in the history
  35. Rename OLD_FILENAME as generated_bottle_filename.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    34ffadf View commit details
    Browse the repository at this point in the history
  36. Only set bash variables once.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6c74f0f View commit details
    Browse the repository at this point in the history
  37. Simplify script/bottle.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    4be2282 View commit details
    Browse the repository at this point in the history
  38. Cleanup .editorconfig.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5fea71e View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    d7d1a55 View commit details
    Browse the repository at this point in the history
  40. Rename script/version_bump as `script/generate_version_info_for_swi…

    …ft`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    d0729ef View commit details
    Browse the repository at this point in the history
  41. Unfinished: Only bump formulae; don't generate them or store them in …

    …git.
    
    Obtain version & revision from most recent version tag in the current branch, not from environment variable or argument.
    
    Do not branch or commit on release.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5b9e8b6 View commit details
    Browse the repository at this point in the history
  42. Fix Makefile comment.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5684c0e View commit details
    Browse the repository at this point in the history
  43. Remove obsolete Makefile target.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    95ba0a6 View commit details
    Browse the repository at this point in the history
  44. Delete script/bottle.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7a7a1df View commit details
    Browse the repository at this point in the history
  45. Just bump custom tap formula.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    94a24e4 View commit details
    Browse the repository at this point in the history
  46. Cleanup homebrew-core release job.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7e135bd View commit details
    Browse the repository at this point in the history
  47. Make brew bump-formula-pr usages consistent.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    4253175 View commit details
    Browse the repository at this point in the history
  48. release.yml: improve comments, remove unnecessary environment varia…

    …bles, and reorder some settings.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f1b637f View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    cb306a6 View commit details
    Browse the repository at this point in the history
  50. Remove unnecessary comments from GitHub workflows.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    98eb31a View commit details
    Browse the repository at this point in the history
  51. Replace external grep dependency with bash conditional.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e2b68d1 View commit details
    Browse the repository at this point in the history
  52. script/install: fix universal executable path.

    Cleanup `script/install`.
    
    `Makefile`: use `${PREFIX}` for `install-universal`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    3ce08fd View commit details
    Browse the repository at this point in the history
  53. Bash scripts: Change all non-environment variable names to lowercase.

    Inline variables that are only used once.
    
    Improve comments.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    0e0d0e4 View commit details
    Browse the repository at this point in the history
  54. release.yml: replace needs.start.outputs.mas_version with `github…

    ….event.release.tag_name`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    9ae7264 View commit details
    Browse the repository at this point in the history
  55. Do not indent cases in bash scripts.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    62cd5ab View commit details
    Browse the repository at this point in the history
  56. Improve dry run.

    `brew_core_update`: disable tracing & cleanup script.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    52ad899 View commit details
    Browse the repository at this point in the history
  57. Incorporate fixes from 638/release-fixes by @phatblat.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    cd8cca4 View commit details
    Browse the repository at this point in the history
  58. release.yml: cleanup line length issues.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    bae6446 View commit details
    Browse the repository at this point in the history
  59. Improve URLs.

    Cleanup comments / documentation / spacing.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    0d22619 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    ced503d View commit details
    Browse the repository at this point in the history
  61. release.yml: Move RELEASE_TAG environment variable to top level.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6a62a92 View commit details
    Browse the repository at this point in the history
  62. release.yml: Improve step names.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    04baa16 View commit details
    Browse the repository at this point in the history
  63. release.yml: Change start job 🔈 Log real release event step if …

    …condition.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    138badb View commit details
    Browse the repository at this point in the history
  64. release.yml: Use environment variables top prevent code injection a…

    …ttacks / accidents.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f7cff25 View commit details
    Browse the repository at this point in the history
  65. release.yml: Use DRY_RUN top-level environment variable instead o…

    …f an output from `start` job.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b670b45 View commit details
    Browse the repository at this point in the history
  66. release.yml: Use !contains(env.RELEASE_TAG, '-') instead of a `pr…

    …e_release` output from `start` job.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    38cf936 View commit details
    Browse the repository at this point in the history
  67. release.yml: Remove unnecessary 👢 Bootstrap step from `homebrew-c…

    …ore` job.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7c06027 View commit details
    Browse the repository at this point in the history
  68. release.yml: Change homebrew-tap.needs from start to `pkg-insta…

    …ller` to ensure that custom tap isn't bumped if the package installer wasn't uploaded to the GitHub release.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    702a03d View commit details
    Browse the repository at this point in the history
  69. release.yml: Combine all separate jobs into one single job to simpl…

    …ify & speedup workflow.
    
    Move all environment variables to the top level.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b710c1e View commit details
    Browse the repository at this point in the history
  70. Replace echo with printf in bash scripts.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    c8fdaf8 View commit details
    Browse the repository at this point in the history
  71. Delete script/brew_core_update & move its homebrew-core/mas bump …

    …into `release.yml`.
    
    Run `git rev-parse …` instead of `git rev-list -n 1 …` for mas-cli/tap/mas.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6472312 View commit details
    Browse the repository at this point in the history
  72. Delete Makefile & seemingly unused bash scripts.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    89bf42d View commit details
    Browse the repository at this point in the history
  73. Delete script/install.

    Requires corresponding commits to `homebrew-core/mas` & `mas-cli/tap/mas` formulae.
    
    Rename `dstroot` variable as `distributions_root` in `script/package`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    bfbfea8 View commit details
    Browse the repository at this point in the history
  74. Fix format violations.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    d5e3d38 View commit details
    Browse the repository at this point in the history
  75. Ensure bash scripts don't use unset variables.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    bd4e0a8 View commit details
    Browse the repository at this point in the history
  76. Update actions/checkout@v4 settings:

    Should only release revisions that have version tags on them, so should only need a single commit.
    
    `ref:` should default to the reference for the event, which should be `github.event.release.tag_name`, so shouldn't need to explicitly set it.
    
    If any of these changes cause problems, will back them out.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    d88ac12 View commit details
    Browse the repository at this point in the history
  77. Improve script modularity:

    `script/package` calls
    `script/build --universal` instead of requiring the latter to be called before the former.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    f49896a View commit details
    Browse the repository at this point in the history
  78. No longer git ignore Sources/MasKit/Package.swift since the `MasKit…

    …` target has been merged into `mas` target.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e262c37 View commit details
    Browse the repository at this point in the history
  79. Cleanup Swift files.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6a60884 View commit details
    Browse the repository at this point in the history
  80. The swift-format formula will only install on macOS 13+.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    eaaf2f3 View commit details
    Browse the repository at this point in the history
  81. Upgrade swiftformat to 0.55.2, prettier to 3.4.1, & markdownlint-cli …

    …to 0.43.0.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    ebb3aa6 View commit details
    Browse the repository at this point in the history
  82. Output full git describe --tags to indicate number of commits since…

    … tag & current revision for local (i.e. non-release builds), since releases should all be for a version tagged revision.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    565017c View commit details
    Browse the repository at this point in the history
  83. Remove unnecessary single quotes from bash scripts.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    7dd2335 View commit details
    Browse the repository at this point in the history
  84. Remove unnecessary swiftlint output filtering from script/lint.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b46afa2 View commit details
    Browse the repository at this point in the history
  85. Use markdownlint on all *.md files.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    fcd7be5 View commit details
    Browse the repository at this point in the history
  86. Remove incorrect comment from script/format.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    0e4805e View commit details
    Browse the repository at this point in the history
  87. Rename linter as formatter in script/format.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    0f93a45 View commit details
    Browse the repository at this point in the history
  88. Change Swift formatter emoji to fix output spacing issues in `script/…

    …format`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    610d7d1 View commit details
    Browse the repository at this point in the history
  89. Make swiftformat --strict in script/format.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    1011e8d View commit details
    Browse the repository at this point in the history
  90. Make swiftlint --quiet in script/format.

    Remove useless `--strict` from `swiftlint` in `script/format`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    6601bee View commit details
    Browse the repository at this point in the history
  91. Filter out boilerplate swiftformat output from script/format.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    bafcfd7 View commit details
    Browse the repository at this point in the history
  92. Filter out boilerplate prettier output from script/format.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    5f8f97e View commit details
    Browse the repository at this point in the history
  93. Filter out boilerplate output from script/test.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    e672c9e View commit details
    Browse the repository at this point in the history
  94. brew bundle no longer generates Brewfile.lock.json.

    Allow `script/bootstrap` to accept any arguments for `brew bundle install`.
    
    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    cdc6132 View commit details
    Browse the repository at this point in the history
  95. 🔥 Remove DRY_RUN var

    phatblat authored and rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    fd6bdc1 View commit details
    Browse the repository at this point in the history
  96. Switch scripts from bash to zsh.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    74131a2 View commit details
    Browse the repository at this point in the history
  97. Remove shfmt because it cannot work with zsh.

    Partial mas-cli#638
    
    Signed-off-by: Ross Goldberg <[email protected]>
    rgoldberg committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    22b255d View commit details
    Browse the repository at this point in the history