Release improvements #640
Draft
Release improvements #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 16, 2024
rgoldberg
force-pushed
the
638-release-improvements
branch
6 times, most recently
from
03de1d2
to
8306c6e
Compare
rgoldberg
force-pushed
the
638-release-improvements
branch
7 times, most recently
from
0faa0f8
to
ef6bd6e
Compare
|
@phatblat I've incorporated your fixes from the If you have any other fixes that weren't already in that branch in this repo at the time when this comment was posted, please share them with me so I can incorporate them into the branch for this PR. Thanks. |
rgoldberg
force-pushed
the
638-release-improvements
branch
4 times, most recently
from
f06fedd
to
4856cee
Compare
Closed
rgoldberg
force-pushed
the
638-release-improvements
branch
3 times, most recently
from
41c1f62
to
aabdb51
Compare
rgoldberg
added
the
🧽 chore
rgoldberg
force-pushed
the
638-release-improvements
branch
from
94bf065
to
02f2bd4
Compare
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
…into `release.yml`. Run `git rev-parse …` instead of `git rev-list -n 1 …` for mas-cli/tap/mas. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Requires corresponding commits to `homebrew-core/mas` & `mas-cli/tap/mas` formulae. Rename `dstroot` variable as `distributions_root` in `script/package`. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Should only release revisions that have version tags on them, so should only need a single commit. `ref:` should default to the reference for the event, which should be `github.event.release.tag_name`, so shouldn't need to explicitly set it. If any of these changes cause problems, will back them out. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
`script/package` calls `script/build --universal` instead of requiring the latter to be called before the former. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
…` target has been merged into `mas` target. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
…to 0.43.0. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
… tag & current revision for local (i.e. non-release builds), since releases should all be for a version tagged revision. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
…format`. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Remove useless `--strict` from `swiftlint` in `script/format`. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Allow `script/bootstrap` to accept any arguments for `brew bundle install`. Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
Partial mas-cli#638 Signed-off-by: Ross Goldberg <[email protected]>
rgoldberg
force-pushed
the
638-release-improvements
branch
from
5a6314f
to
22b255d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@phatblat
I've incorporated your fixes from https://github.com/mas-cli/mas/tree/638/release-fixes into the branch for this PR, and the 1.8.8-beta.1 test run doesn't need to be released, so we should be able to delete the following branches:
I've repeatedly rebased this PR's branch, so if you want to look at (or test) my release process, please force pull this PR's branch before looking at it.
Moved workflow description to the issue #638
Resolve #638, #636, #635, #634, #628