Skip to content

Commit

Permalink
relax resampy version requirement to support python3.12 (#103)
Browse files Browse the repository at this point in the history
Currently crepe requires `resampy>=0.2.0,<0.3.0`. The problem is that versions of resampy within that range do not work with Python 3.12:

```
$ docker run --rm python:3.12 pip install resampy==0.2.2
Collecting resampy==0.2.2
  Downloading resampy-0.2.2.tar.gz (323 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 323.4/323.4 kB 3.0 MB/s eta 0:00:00
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-jlno0zv0/resampy_5f2a2a60b1594dfc8ec1f1e16ad51fdb/setup.py", line 2, in <module>
          import imp
      ModuleNotFoundError: No module named 'imp'
      [end of output]
```

However `resampy==0.3.0` (and higher) works:

```
$  docker run --rm -it python:3.12 pip install resampy==0.3.0
...
Successfully installed llvmlite-0.43.0 numba-0.60.0 numpy-2.0.0 resampy-0.3.0
```

This PR relaxes the `resampy<0.3.0` requirement to allow crepe to work with python3.12
  • Loading branch information
tandav authored Aug 19, 2024
1 parent 37c7060 commit ed06fa7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
numpy>=1.14.0
scipy>=1.0.0
matplotlib>=2.1.0
resampy>=0.2.0,<0.3.0
resampy>=0.2.0
h5py
hmmlearn>=0.3.0
imageio>=2.3.0
Expand Down

0 comments on commit ed06fa7

Please sign in to comment.