Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use full file extension for compiler imports #1762

Merged
merged 1 commit into from
Jan 2, 2022

Conversation

DylanPiercey
Copy link
Contributor

Description

Includes a subset of changes from #1728.
This PR makes it so that imports added in the compiled output include the full file path with extension which improves support for loading compiled Marko templates in node's ESM mode.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #1762 (0b77be0) into main (cf3ed5c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1762   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         223      223           
  Lines        6827     6827           
=======================================
  Hits         6161     6161           
  Misses        666      666           
Impacted Files Coverage Δ
packages/translator-default/src/index.js 94.48% <ø> (ø)
.../translator-default/src/placeholder/index[html].js 100.00% <ø> (ø)
...ator-default/src/tag/attribute/directives/class.js 100.00% <ø> (ø)
...ator-default/src/tag/attribute/directives/style.js 100.00% <ø> (ø)
packages/translator-default/src/tag/custom-tag.js 100.00% <ø> (ø)
packages/translator-default/src/tag/dynamic-tag.js 88.88% <ø> (ø)
...tor-default/src/tag/native-tag[html]/attributes.js 100.00% <ø> (ø)
...anslator-default/src/tag/native-tag[html]/index.js 100.00% <ø> (ø)
...anslator-default/src/tag/native-tag[vdom]/index.js 97.01% <ø> (ø)
...es/translator-default/src/util/add-dependencies.js 83.33% <ø> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf3ed5c...0b77be0. Read the comment docs.

@DylanPiercey DylanPiercey merged commit 041011a into main Jan 2, 2022
@DylanPiercey DylanPiercey deleted the include-extension-imports branch January 2, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant