Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove created-by headers and update LICENSE/Copyright #518

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

KiwiKilian
Copy link
Collaborator

@KiwiKilian KiwiKilian commented Nov 27, 2024

  • Removed comment/created-by headers and copyrights
    • Aligned with the MapLibre Native repo which also doesn't have those headers
    • Added the Mapbox copyright to License

@@ -1,5 +1,7 @@
Copyright (c) 2022 MapLibre contributors

Copyright (c) 2017 Mapbox Inc.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this code originally copyrighted/licensed by Mapbox? Why was it missing in the first place? Adding / Removing should be a question for the Maplibre board.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the history: https://github.com/maplibre/maplibre-react-native/commits/main/LICENSE.md

This project was started by Mapbox. The copyright notice was removed roughly around the point the project went into community hands. But still the copyright notice was around in many file headers. So by removing the individual file headers, I would say we do right by adding/keeping the copyright in the LICENSE.

We even may drop the last paragraph:

This project was originally forked from https://github.com/rnmapbox/maps, also under the MIT license, but without a copyright holder notice.

What do you think @lseelenbinder?

@KiwiKilian KiwiKilian changed the title refactor: rename RCTMLN to MLRN chore: remove created-by headers and update LICENSE/Copyright Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants