Updated image entity fields #155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Rubix982
suggested changes
Jun 11, 2024
There was a problem hiding this comment.
The changes are good. LGTM.
I noticed there is an additional field under the field header under Images for detections. I think that needs to be added as well for documentation's sake.
That is all the change that I see that needs to be addressed. Everything else is good to go.
@cbeddow any thoughts here?
| 23. quality_score - float, how good the image is (experimental) | ||
| 24. sequence - string, ID of the sequence | ||
| 25. sfm_cluster - { id: string, url: string } - URL to the point cloud | ||
| 26. width - int, width of the original image uploaded | ||
| ``` |
There was a problem hiding this comment.
I think there needs to be the mention for detections as well, given the last item under width for the fields under the Image entity,
https://www.mapillary.com/developer/api-documentation#image
|
|
||
|
|
||
| 22. width - int, width of the original image uploaded | ||
| 26. width - int, width of the original image uploaded |
There was a problem hiding this comment.
LGTM! 👍
Docs can be updated with the make docs-gen command as well to avoid manual updates. This also requires the detections item.
| 23. quality_score - float, how good the image is (experimental) | ||
| 24. sequence - string, ID of the sequence | ||
| 25. sfm_cluster - { id: string, url: string } - URL to the point cloud | ||
| 26. width - int, width of the original image uploaded |
| 23. quality_score - float, how good the image is (experimental) | ||
| 24. sequence - string, ID of the sequence | ||
| 25. sfm_cluster - { id: string, url: string } - URL to the point cloud | ||
| 26. width - int, width of the original image uploaded |
| 23. quality_score - float, how good the image is (experimental) | ||
| 24. sequence - string, ID of the sequence | ||
| 25. sfm_cluster - { id: string, url: string } - URL to the point cloud | ||
| 26. width - int, width of the original image uploaded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated image entity fields to add creator, make, model, and thumb_original_url. Thus fields are documented at https://www.mapillary.com/developer/api-documentation#image .