Fix some issues with deactivating the plugin with Meteor #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsabran
referenced
this pull request
Jun 23, 2016
When running this babel-plugin inside Meteor, it gives us weird errors. But, we don't need this to use inside Meteor. Meteor do this for us automatically. So, we simply turn off this when using inside Meteor.
| // Here's we detect the use of Meteor that interferes with path resolution | ||
| // global.meteorBabelHelpers is something we can see when | ||
| // running inside Meteor. | ||
| if (global.meteorBabelHelpers && path.startsWith(this.root)) { |
There was a problem hiding this comment.
We need to remove path.startsWith(this.root) to make this work.
Make sure to do meteor reset and before using this.
(and call npm run compile in this repo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch 1.1.0 deactivates the plugin when Meteor is running. In some context (for instance with webpack:webpack), the plugin is still needed so we have to do a more subtle fix.