incus: Improve completion for file push and file pull
#1445
+154
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The completion functions for instance and remote names now only return names prefixed by the string to be completed. This allows the caller of these functions to improve their decisions about their own completion behaviour. Signed-off-by: montag451 <[email protected]>
montag451
force-pushed
the
file-push-pull-comp
branch
from
c567c36
to
6e51f3d
Compare
montag451
force-pushed
the
file-push-pull-comp
branch
3 times, most recently
from
8363c66
to
68a936a
Compare
Signed-off-by: montag451 <[email protected]>
montag451
force-pushed
the
file-push-pull-comp
branch
from
68a936a
to
d09af53
Compare
stgraber
approved these changes
Dec 2, 2024
|
@stgraber Can you rerun the checks please, I don't think my changes are responsible for the failure so running the checks again should fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completion for files inside instances is not provided as I don't know how to do it properly for the moment, the improvement concerns the fact that instances names are now returned as completion candidates. Before only local file names was provided.