Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rv_core_ibex,rtl] Parametrize alert_handler dependencies #25471

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Razer6
Copy link
Member

@Razer6 Razer6 commented Nov 30, 2024

Not all tops with an Ibex have an alert handler and its package. This PR removes the dependency of the alert handler from Ibex by parametrizing those values. The top-level then connects the alert handler definitions to those parameters.

Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me.

@andreaskurth
Copy link
Contributor

andreaskurth commented Dec 2, 2024

CHANGE AUTHORIZED: hw/ip/rv_core_ibex/data/rv_core_ibex.hjson
CHANGE AUTHORIZED: hw/ip/rv_core_ibex/rtl/rv_core_ibex.sv
CHANGE AUTHORIZED: hw/top_earlgrey/data/top_earlgrey.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

The way alert handler properties are passed to rv_core_ibex got changed, but the values stay the same, so no functional difference.

@vogelpi
Copy link
Contributor

vogelpi commented Dec 2, 2024

CHANGE AUTHORIZED: hw/ip/rv_core_ibex/data/rv_core_ibex.hjson
CHANGE AUTHORIZED: hw/ip/rv_core_ibex/rtl/rv_core_ibex.sv
CHANGE AUTHORIZED: hw/top_earlgrey/data/top_earlgrey.hjson
CHANGE AUTHORIZED: hw/top_earlgrey/rtl/autogen/top_earlgrey.sv

The way alert handler properties are passed to rv_core_ibex got changed, but the values stay the same, so no functional difference.

@andreaskurth andreaskurth merged commit 6e3f575 into lowRISC:master Dec 2, 2024
37 checks passed
@Razer6 Razer6 deleted the parametrize-rv-core-ibex branch December 2, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants