Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dv] Add GUI debug mode for Riviera #25451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dariuszst
Copy link

Hi,
I added a missing riviera_gui_debug mode required after f88269d update.
This is an initial version allowing running tests with dvsim.py script.

@dariuszst dariuszst requested a review from a team as a code owner November 28, 2024 13:34
@dariuszst dariuszst requested review from marnovandermaas and removed request for a team November 28, 2024 13:34
Copy link
Contributor

@rswarbrick rswarbrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable, but needs a bit of tidying up.

  • For the TODO note, I think we should be able to explain what's going on without needing to call out to a merged PR.
  • I think the two commits probably need squashing together.

Add a missing riviera_gui_debug mode - initial version
Signed-off-by: Dariusz Stachanczyk <[email protected]>
@dariuszst
Copy link
Author

Thanks @rswarbrick - I've updated my fork repository (removed this unnecessary commit) and I hope the change is now referenced correctly. I changed also the TODO note - is it OK now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants