[alert,dv] Fix logic in alert_receiver_driver #25272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rswarbrick
added
Component:DV
rswarbrick
requested review from
marnovandermaas
and removed request for
a team
alees24
approved these changes
Nov 27, 2024
This was "tightened up" in commit b1095ff, which actually broke things! The problem is that I was imagining the "continue" would continue in the surrounding "forever" loop. But it doesn't! It just skips an iteration of the "repeat" loop inside. Make the logic a bit more explicit and correctly handle the case where we go into reset with the clock paused. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
force-pushed
the
alert-receiver-driver-fix
branch
from
2fb76ad
to
98f070b
Compare
|
It gets more embarrassing: my "fix" in this PR didn't actually work! I've just pushed a version that does (because it no longer drops alerts on a reset). Sorry about that. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was "tightened up" in commit b1095ff, which actually broke things! The problem is that I was imagining the "continue" would continue in the surrounding "forever" loop. But it doesn't! It just skips an iteration of the "repeat" loop inside.
Make the logic a bit more explicit and correctly handle the case where we go into reset with the clock paused.
(@KinzaQamar: Thanks for finding and diagnosing this bug)