[pwm,dv] Exclude some more impossible toggle coverage items #25140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honestly, this isn't really a pwm-specific change so we'll probably
want to move it eventually. Before this change, he reported toggle
coverage misses bits 56:43 of data_i in tb.dut.u_reg.u_chk.u_chk. This
instance is made with:
prim_secded_inv_64_57_dec u_chk (
.data_i({tl_i.a_user.cmd_intg, H2DCmdMaxWidth'(cmd)}),
.data_o(),
.syndrome_o(),
.err_o(err)
);
where cmd is 43 bits wide and H2DCmdMaxWidth is 57. As such, bits
56:43 are constant.
Signed-off-by: Rupert Swarbrick <[email protected]>
For the first item (d_param and d_sink), the fields are genuinely constant. For the second item, the rsp_intg signal is calculated as a hash of a small value. Local attempts to change it, watching a wave viewer, didn't actually see the top bit change. I'm not sure if it's actually impossible to hit, but waiving the coverage seems reasonable in this case. Signed-off-by: Rupert Swarbrick <[email protected]>
This is wired to a constant, so definitely won't change. Signed-off-by: Rupert Swarbrick <[email protected]>
rswarbrick
requested review from
marnovandermaas
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #25135 which contains the first commit. The following two commits exclude another couple of impossible toggle coverage items (with detailed notes). With these changes merged, we can actually see 100% toggle coverage.