Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for django 5 #9

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Add support for django 5 #9

merged 3 commits into from
Oct 15, 2024

Conversation

ktowen
Copy link
Collaborator

@ktowen ktowen commented Sep 23, 2024

No description provided.

@ktowen ktowen marked this pull request as draft September 23, 2024 20:38
@ktowen ktowen force-pushed the master branch 3 times, most recently from e4ad0f1 to 8652871 Compare September 24, 2024 15:40
@ktowen ktowen marked this pull request as ready for review September 24, 2024 15:57
lorinkoz
lorinkoz approved these changes Oct 1, 2024
View reviewed changes
Copy link
Owner

@lorinkoz lorinkoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good overall.

Would you do me one BIG favor? Please find all occurrences of "djsc_sandbox" and rename it to just "sandbox", including the folder rename. Thanks!

Feel free to bump the version and release yourself when ready.

@ktowen ktowen merged commit e41e1be into lorinkoz:master Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorinkoz lorinkoz lorinkoz approved these changes

Assignees

@lorinkoz lorinkoz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ktowen @lorinkoz