feature(rwx): add FilesystemResize method and request #30
Conversation
|
@james-munson need to execute |
james-munson
force-pushed
the
9736-rwx-resize
branch
from
1c245e9
to
f7f62e9
Compare
james-munson
force-pushed
the
9736-rwx-resize
branch
from
f7f62e9
to
94a7bed
Compare
| @@ -10,6 +10,7 @@ option go_package = "github.com/longhorn/types/pkg/generated/smrpc"; | |||
| import "google/protobuf/empty.proto"; | |||
|
|
|||
| service ShareManagerService { | |||
| rpc FilesystemResize(google.protobuf.Empty) returns (google.protobuf.Empty) {} | |||
There was a problem hiding this comment.
No need the new and old sizes?
There was a problem hiding this comment.
That's correct - the fs utility, either resize2fs or xfs_growfs recognizes the necessary growth and just does the right thing.
There was a problem hiding this comment.
Do we need a method to get the current size of the filesystem inside share manager? Like this one is set method and the new one is get method?
There was a problem hiding this comment.
A good question. Shall I write a separate ticket for that? I'd hate to hold this up for it.
There was a problem hiding this comment.
Thinking about it again, I think we can skip it for now. We can add them later when we need the new function
Signed-off-by: James Munson <[email protected]>
Signed-off-by: James Munson <[email protected]>
james-munson
force-pushed
the
9736-rwx-resize
branch
from
94a7bed
to
cffd572
Compare
Which issue(s) this PR fixes:
Issue: longhorn/longhorn#9736 aka longhorn/longhorn#8118
What this PR does / why we need it:
Add an RPC call for FilesystemResize to the share-manager interface.
Special notes for your reviewer:
Additional documentation or context