Expose P99 latency and support customizable IO testing with selective IO types and metrics #9
+598
−475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CPU idleness introduces extra overhead and storage performance drop. By default, the profiling is disabled. Signed-off-by: Derek Su <[email protected]>
shuo-wu
approved these changes
Apr 8, 2024
Users have the option to select specific IO types, including random read (randread), random write (randwrite), sequential read (seqread), and sequential write (seqwrite), as well as metrics like IOPS, bandwidth, and latency. There's no requirement to conduct all tests. Longhorn 8254 Signed-off-by: Derek Su <[email protected]>
Expose 99th percentile. It means that 99% of the requests should be faster than given latency. Longhorn 8254 Signed-off-by: Derek Su <[email protected]>
PhanLe1010
reviewed
Apr 9, 2024
There was a problem hiding this comment.
Looks like this PR has big overlap with my other PR #7 . That other PRs also added many test modes.
Could we review and merge that PR first and build this one on top of it? @derekbit @shuo-wu @innobead. After the other PR is merged, I can update this PR to include the p99 if Derek is busy. Is it ok?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customizable IO testing with selective IO types and metrics
Users have the option to select specific IO types, including random read (randread),
random write (randwrite), sequential read (seqread), and sequential write (seqwrite),
as well as metrics like IOPS, bandwidth, and latency.
There's no requirement to conduct all tests.
Expose P99 latency
Expose 99th percentile. It means that 99% of the requests should be faster than given latency.
longhorn/longhorn#8254