Add ability to filter logs send to Better Stack #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will be adding the info to our Ruby & Rails docs, and possibly to |
curusarn
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Look s good, thanks.
I agree with dropping ruby 2.2 - it looks like almost nobody used it in 2019 already: https://www.jetbrains.com/lp/devecosystem-2019/ruby/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/fXPatrDE/3405-clientsruby-rails-add-configurable-filtering-of-logs-sent-to-better-stack
Resolves logtail/logtail-ruby-rails#22. I intentionally added the check to HTTP log device as the reason for not sending too many logs to Better Stack is to keep the logged amount lower, not dropping logs per se. Also, there's already LogEntry object which helps with accessing different properties in a nice manner.
Example added to method annotations and example-project.
Ruby 2.2 does not support
&.syntax. Since it's official support ended in 2018, I suggest we just drop it.