Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hofund connection tags #58

Merged
merged 4 commits into from
Nov 27, 2024

Conversation

witx98
Copy link
Member

@witx98 witx98 commented Nov 27, 2024

Closes #57

Result:

# HELP hofund_info Basic information about application
# TYPE hofund_info gauge
hofund_info{application_name="hofundtest",application_version="0.0.1-SNAPSHOT",id="hofundtest"} 1
# HELP hofund_connection Current status of given connection
# TYPE hofund_connection gauge
hofund_connection{description="",id="hofundtest-google_http",source="hofundtest",target="google",type="http"} 1.0
hofund_connection{description="PostgreSQL",id="hofundtest-mydatabase_database",source="hofundtest",target="mydatabase_database",type="database"} 1.0
# HELP hofund_edge Information about hofund edge, value is always 1.0, to check status use hofund_connection
# TYPE hofund_edge gauge
hofund_edge{id="hofundtest-google_http",source="hofundtest",target="google",type="http"} 1.0
hofund_edge{id="hofundtest-mydatabase_database",source="hofundtest",target="mydatabase_database",type="database"} 1.0
# HELP hofund_node Information about hofund nodes, value is always 1.0, to check status use hofund_info
# TYPE hofund_node gauge
hofund_node{id="google",subtitle="http ()",title="google_http",type="http"} 1.0
hofund_node{id="hofundtest",subtitle="0.0.1-SNAPSHOT",title="hofundtest",type="app"} 1.0
hofund_node{id="mydatabase_database",subtitle="database (PostgreSQL)",title="mydatabase_database",type="database"} 1.0

@witx98 witx98 self-assigned this Nov 27, 2024
@witx98
Copy link
Member Author

witx98 commented Nov 27, 2024

@marwin1991

Should we remove parentheses when the description is empty - http ()?

# Conflicts:
#	hofund-spring/src/main/java/dev/logchange/hofund/connection/spring/datasource/DataSourceConnectionFactory.java
@marwin1991 marwin1991 merged commit ebce197 into logchange:master Nov 27, 2024
2 checks passed
@witx98 witx98 mentioned this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prometheus requires that all meters with the same name have the same set of tag keys
2 participants