Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: update entra id sso document #4168

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

EINDEX
Copy link
Contributor

@EINDEX EINDEX commented Sep 27, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

Update document for Entra ID.

📝 补充信息 | Additional Information

Copy link

vercel bot commented Sep 27, 2024

@EINDEX is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Sep 27, 2024
@lobehubbot
Copy link
Member

👍 @EINDEX

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 📝 Documentation Improvements or additions to documentation | 文档问题 label Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.27%. Comparing base (8ddb41b) to head (09a426b).
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4168      +/-   ##
==========================================
- Coverage   92.50%   92.27%   -0.24%     
==========================================
  Files         484      489       +5     
  Lines       34735    35077     +342     
  Branches     2143     3375    +1232     
==========================================
+ Hits        32132    32366     +234     
- Misses       2603     2711     +108     
Flag Coverage Δ
app 92.27% <100.00%> (-0.24%) ⬇️
server 97.37% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented Sep 27, 2024

只需要改文档就好了么?不需要改实现?

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Is it just a matter of changing the document? No need to change the implementation?

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Sep 27, 2024
@EINDEX
Copy link
Contributor Author

EINDEX commented Sep 27, 2024

@arvinxx Sorry, that time is not ready for review.

I added a new SSO module for Microsoft Entra ID and kept the old Azure AD.

For the documentation side, there is no setting up process from Azure AD to Entra ID. Only the env vars and redirect URL path are updated by the Next Auth package.

PS: My mbp m1 pro with 16G RAM is very slow to build this project 😭.

@EINDEX
Copy link
Contributor Author

EINDEX commented Oct 1, 2024

@arvinxx please review this PR

@EINDEX EINDEX changed the title 📝 docs: update entra id sso document ✨ feat: update entra id sso document Oct 1, 2024
src/config/auth.ts Outdated Show resolved Hide resolved
src/libs/next-auth/sso-providers/microsoft-entra-id.ts Outdated Show resolved Hide resolved
src/libs/next-auth/sso-providers/microsoft-entra-id.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Oct 2, 2024
docs/self-hosting/environment-variables/auth.zh-CN.mdx Outdated Show resolved Hide resolved
src/config/auth.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 12, 2024
src/config/auth.ts Outdated Show resolved Hide resolved
@EINDEX
Copy link
Contributor Author

EINDEX commented Oct 19, 2024 via email

@EINDEX
Copy link
Contributor Author

EINDEX commented Oct 19, 2024

@arvinxx please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Improvements or additions to documentation | 文档问题 size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants