-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat: update entra id sso document #4168
base: main
Are you sure you want to change the base?
Conversation
@EINDEX is attempting to deploy a commit to the LobeChat Community Team on Vercel. A member of the Team first needs to authorize it. |
👍 @EINDEX Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4168 +/- ##
==========================================
- Coverage 92.50% 92.27% -0.24%
==========================================
Files 484 489 +5
Lines 34735 35077 +342
Branches 2143 3375 +1232
==========================================
+ Hits 32132 32366 +234
- Misses 2603 2711 +108
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
只需要改文档就好了么?不需要改实现? |
Is it just a matter of changing the document? No need to change the implementation? |
@arvinxx Sorry, that time is not ready for review. I added a new SSO module for For the documentation side, there is no setting up process from Azure AD to Entra ID. Only the env vars and redirect URL path are updated by the Next Auth package. PS: My mbp m1 pro with 16G RAM is very slow to build this project 😭. |
@arvinxx please review this PR |
抱歉 我还没改 换了个电脑 环境崩了Sent from my iPhoneOn Oct 19, 2024, at 10:45, Arvin Xu ***@***.***> wrote:
@arvinxx commented on this pull request.
In src/config/auth.ts:
@@ -265,6 +270,13 @@ export const getAuthConfig = () => {
// Casdoor
CASDOOR_WEBHOOK_SECRET: process.env.CASDOOR_WEBHOOK_SECRET,
+
+ // Microsoft Entra ID
+ MICROSOFT_ENTRA_ID_ID: process.env.MICROSOFT_ENTRA_ID_ID || process.env.AZURE_AD_CLIENT_ID,
为啥还需要加 MICROSOFT_ENTRA_ID_ID ? 这三个变量应该不需要了吧?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
@arvinxx please review |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
Update document for Entra ID.
📝 补充信息 | Additional Information