Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

โœจ feat: allow commercial license to customize inbox assistant #4148

Open
wants to merge 45 commits into
base: main
Choose a base branch
from

Conversation

khanhduyvt0101
Copy link
Contributor

@khanhduyvt0101 khanhduyvt0101 commented Sep 26, 2024

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

Commercial license dev can set feature flag commercial_inbox = true to enable customizing the default inbox assistant. The customization is done through a dedicated locale file custom.ts to avoid conflict from other updates.

Copy link

vercel bot commented Sep 26, 2024

@khanhduyvt0101 is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 26, 2024
@lobehubbot
Copy link
Member

๐Ÿ‘ @khanhduyvt0101

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 92.28%. Comparing base (8a0e45c) to head (eaf8090).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #4148    +/-   ##
========================================
  Coverage   92.28%   92.28%            
========================================
  Files         488      489     +1     
  Lines       35169    35202    +33     
  Branches     2300     2159   -141     
========================================
+ Hits        32454    32487    +33     
  Misses       2715     2715            
Flag Coverage ฮ”
app 92.28% <100.00%> (+<0.01%) โฌ†๏ธ
server 97.37% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@khanhduyvt0101 khanhduyvt0101 changed the title Using env to custom title, description, prompt for default assistance Allow commercial license to customize default assistant Sep 26, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 26, 2024
@khanhduyvt0101 khanhduyvt0101 changed the title Allow commercial license to customize default assistant feat: allow commercial license to customize default assistant Sep 26, 2024
@khanhduyvt0101 khanhduyvt0101 changed the title feat: allow commercial license to customize default assistant feat: allow commercial license to customize inbox assistant Sep 26, 2024
@arvinxx
Copy link
Contributor

arvinxx commented Sep 26, 2024

@khanhduyvt0101 hi, could you please seperate a PR just for the code format & lint fix? I think this PR should focus on the customize~

@khanhduyvt0101
Copy link
Contributor Author

@khanhduyvt0101 hi, could you please seperate a PR just for the code format & lint fix? I think this PR should focus on the customize~

Here you go, please merge this PR first: #4161, then I'll update this one. @arvinxx

@khanhduyvt0101
Copy link
Contributor Author

@arvinxx , Please consider and merge this PR man

@arvinxx
Copy link
Contributor

arvinxx commented Sep 27, 2024

@khanhduyvt0101 yeah, I think this idea is great. I'm reviewing the code now

@khanhduyvt0101 khanhduyvt0101 changed the title feat: allow commercial license to customize inbox assistant โœจ feat: allow commercial license to customize inbox assistant Sep 27, 2024
@khanhduyvt0101
Copy link
Contributor Author

Just updated based on your review @arvinxx

Copy link
Contributor

@arvinxx arvinxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the custom locale may not be a good pattern. Because most users don't need this file but it will be bundled to all users. Need to discuss a better way to handle it

src/config/featureFlags/schema.ts Outdated Show resolved Hide resolved
src/const/guide.ts Outdated Show resolved Hide resolved
@khanhduyvt0101
Copy link
Contributor Author

the custom locale may not be a good pattern. Because most users don't need this file but it will be bundled to all users. Need to discuss a better way to handle it

Hi @arvinxx, I updated the code base based on your feedback. The custom locales only generate when isCustomBranding=true

@khanhduyvt0101
Copy link
Contributor Author

Hi @arvinxx , Could you please help me re-consider this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ’„ Design Design an style | ๆ ทๅผ้—ฎ้ข˜ size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants