-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: added character input #3
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for your pull request 👍.
I don't think it's very useful to have the character name input without doing something with it (except changing the title).
It would be a good feature if you can track the activities for multiple of your characters.
Example:
I have two characters and play with my main character first. I track some progress for my main character and sign in to my second character in-game.
Then, I like to track the progress for this character too, but the aeternum-tracker is still showing the progress for my main.
In this case, I need to be able to select (and add/edit/remove) characters, which have their own activity progress.
return ( | ||
<header className="fixed left-0 top-0 z-50 flex w-full justify-center border-b bg-gradient-to-b py-2 backdrop-blur-2xl border-neutral-800 bg-zinc-800/30 from-inherit"> | ||
<div className="container mx-auto flex items-center gap-2"> | ||
<p className="text-lg md:text-2xl font-extrabold tracking-tight grow whitespace-nowrap"> | ||
Aeternum Tracker | ||
</p> | ||
|
||
<input |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a Input
component which is already styled. See https://github.com/lmachens/aeternum-tracker/blob/main/components/ui/input.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out.
Yes, that's a good point. I need to figure out first how can the tracker call the data of a character. |
@lmachens I see that aeternum-tracker does not have a feature for character login. Would it be a good idea to implement a similar code from aeternum-map for login? Or is there a better approach for tracking multiple characters? |
It's enough to have a simple input to enter and maintain the character name by yourself and save it in the local storage (you can use the persistent zustand store which is used to persist the activities). I would not implement anything which involves a login or server side action. |
@lmachens so the workflow would be:
|
Yes. You can try out how it works now. You can complete or reset the activities and create and maintain custom activities. |
Work is still in progress. I am reading more about the library "zustand" and how to use it. |
Currently, facing an error when updating a store:
|
This PR adds an input element to allow the user inputting a character name, which will change the title of the page to that character name as well.