Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TorchToArith rewrite pattern for AtenGtFloatOp #3892

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Add TorchToArith rewrite pattern for AtenGtFloatOp #3892

merged 1 commit into from
Nov 26, 2024

Conversation

jinchen62
Copy link
Collaborator

No description provided.

@jinchen62 jinchen62 mentioned this pull request Nov 26, 2024
Merged
zjgarvey
zjgarvey approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lit test would be nice, but this is pretty straightforward. Thanks, Jinchen.

@jinchen62 jinchen62 merged commit 0a85486 into llvm:main Nov 26, 2024
3 checks passed
@jinchen62 jinchen62 deleted the gt_float branch November 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjgarvey zjgarvey zjgarvey approved these changes

@vivekkhandelwal1 vivekkhandelwal1 Awaiting requested review from vivekkhandelwal1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinchen62 @zjgarvey