[CIR][Dialect] Add BinOpKind_Max #1201
Open
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Dec 3, 2024
| if (mlir::isa<cir::IntType, mlir::IntegerType>(type)) { | ||
| auto isUnsigned = mlir::isa<cir::IntType>(type) | ||
| ? mlir::cast<cir::IntType>(type).isUnsigned() | ||
| : mlir::cast<mlir::IntegerType>(type).isUnsigned(); |
There was a problem hiding this comment.
Why do we need to check both CIR and LLVM types? If you get the type from the adaptor you only need to check the LLVM one? I see the same happens for cir::BinOpKind::{Div,Rem} but since you are here probably clean up that as well?
There was a problem hiding this comment.
Sure, I was confused why we check mlir::IntegerType too, now it sounds like it might be just historical. I'll clean it up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would facilitate implementation of neon intrinsic
neon_vmax_vand__builtin_elementwise_max, and potentially future optimizations. CIR BinOp supports vector type.Floating point has already been supported by FMaxOp.