Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add subscriber k8s fuzz test #4912

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions chaoscenter/subscriber/pkg/k8s/client.go
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package k8s

import (
"fmt"

wfclientset "github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned"
v1alpha12 "github.com/argoproj/argo-workflows/v3/pkg/client/clientset/versioned/typed/workflow/v1alpha1"
"k8s.io/client-go/discovery"
Expand All @@ -14,11 +16,19 @@ var KubeConfig *string

// getKubeConfig setup the config for access cluster resource
func (k8s *k8sSubscriber) GetKubeConfig() (*rest.Config, error) {
// Use in-cluster config if kubeconfig path is not specified
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep this line?

if KubeConfig == nil {
return rest.InClusterConfig()
}

if *KubeConfig == "" {
return rest.InClusterConfig()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if KubeConfig == nil {
return rest.InClusterConfig()
}
if *KubeConfig == "" {
return rest.InClusterConfig()
}
if *KubeConfig == "" || KubeConfig == nil {
return rest.InClusterConfig()
}

return clientcmd.BuildConfigFromFlags("", *KubeConfig)

config, err := clientcmd.BuildConfigFromFlags("", *KubeConfig)
if err != nil {
return nil, fmt.Errorf("failed to build config from kubeconfig: %v", err)
}
return config, nil
}

func (k8s *k8sSubscriber) GetGenericK8sClient() (*kubernetes.Clientset, error) {
Expand Down
38 changes: 38 additions & 0 deletions chaoscenter/subscriber/pkg/k8s/fuzz/client_fuzz_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
package fuzz

import (
"subscriber/pkg/graphql"
"subscriber/pkg/k8s"
"testing"

fuzz "github.com/AdaLogics/go-fuzz-headers"
)

func FuzzGenerateArgoClient(f *testing.F) {
f.Fuzz(func(t *testing.T, data []byte) {
fuzzConsumer := fuzz.NewConsumer(data)
targetStruct := &struct {
namespace string
}{}
err := fuzzConsumer.GenerateStruct(targetStruct)
if err != nil {
return
}

if targetStruct.namespace == "" {
targetStruct.namespace = "default-namespace"
}
subscriberGraphql := graphql.NewSubscriberGql()
subscriberK8s := k8s.NewK8sSubscriber(subscriberGraphql)

wfClient, err := subscriberK8s.GenerateArgoClient(targetStruct.namespace)
if err != nil {
t.Logf("Unexpected error: %v", err)
return
}

if wfClient == nil {
t.Errorf("Returned payload is nil")
}
})
}
108 changes: 108 additions & 0 deletions chaoscenter/subscriber/pkg/k8s/fuzz/log_fuzz_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
package fuzz

import (
"subscriber/pkg/graphql"
"subscriber/pkg/k8s"
"subscriber/pkg/types"
"testing"

fuzz "github.com/AdaLogics/go-fuzz-headers"
)

func FuzzGetLogs(f *testing.F) {
f.Fuzz(func(t *testing.T, data []byte) {
fuzzConsumer := fuzz.NewConsumer(data)
targetStruct := &struct {
PodName string
Namespace string
Container string
}{}

err := fuzzConsumer.GenerateStruct(targetStruct)
if err != nil {
t.Skip("Failed to generate struct:", err)
return
}

subscriberGraphql := graphql.NewSubscriberGql()
if subscriberGraphql == nil {
t.Fatalf("Failed to create a GraphQL subscriber")
}

subscriberK8s := k8s.NewK8sSubscriber(subscriberGraphql)
if subscriberK8s == nil {
t.Fatalf("Failed to create a Kubernetes subscriber")
}

response, err := subscriberK8s.GetLogs(targetStruct.PodName, targetStruct.Namespace, targetStruct.Container)
if err != nil {
t.Logf("Unexpected error: %v", err)
return
}
if response == "" {
t.Errorf("Returned payload is nil")
}
})
}

func FuzzCreatePodLogs(f *testing.F) {
f.Fuzz(func(t *testing.T, data []byte) {
fuzzConsumer := fuzz.NewConsumer(data)
targetStruct := &struct {
podLog types.PodLogRequest
}{}
err := fuzzConsumer.GenerateStruct(targetStruct)
if err != nil {
return
}
subscriberGraphql := graphql.NewSubscriberGql()
subscriberK8s := k8s.NewK8sSubscriber(subscriberGraphql)
_, err = subscriberK8s.CreatePodLog(targetStruct.podLog)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
})
}

func FuzzSendPodLogs(f *testing.F) {
f.Fuzz(func(t *testing.T, data []byte) {
fuzzConsumer := fuzz.NewConsumer(data)
targetStruct := &struct {
infraData map[string]string
podLog types.PodLogRequest
}{}
err := fuzzConsumer.GenerateStruct(targetStruct)
if err != nil {
return
}
subscriberGraphql := graphql.NewSubscriberGql()
subscriberK8s := k8s.NewK8sSubscriber(subscriberGraphql)
subscriberK8s.SendPodLogs(targetStruct.infraData, targetStruct.podLog)
})
}

func FuzzGenerateLogPayload(f *testing.F) {
f.Fuzz(func(t *testing.T, data []byte) {
fuzzConsumer := fuzz.NewConsumer(data)
targetStruct := &struct {
cid string
accessKey string
version string
podLog types.PodLogRequest
}{}
err := fuzzConsumer.GenerateStruct(targetStruct)
if err != nil {
return
}
subscriberGraphql := graphql.NewSubscriberGql()
subscriberK8s := k8s.NewK8sSubscriber(subscriberGraphql)
response, err := subscriberK8s.GenerateLogPayload(targetStruct.cid, targetStruct.accessKey, targetStruct.version, targetStruct.podLog)
if err != nil {
t.Errorf("Unexpected error: %v", err)
}
if response == nil {
t.Errorf("Returned payload is nil")
}

})
}
Loading
Loading