docs: Add docs for Argo Workflow controller-instanceid label (#290) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiha-min-thant
requested review from
divya-mohan0209,
ksatchit and
k8s-dev
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bjoky
approved these changes
Oct 2, 2024
neelanjan00
approved these changes
Oct 2, 2024
…haos#290) - Added a section to explain the requirement of the `workflows.argoproj.io/controller-instanceid` label in the Workflow YAML. - Included an example showing where to add the label. - Explained how to retrieve the instanceID value from the workflow-controller-configmap. Signed-off-by: Thiha Min Thant <[email protected]>
…os#290 Signed-off-by: Thiha Min Thant <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Thiha Min Thant <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Thiha Min Thant <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Thiha Min Thant <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Thiha Min Thant <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Thiha Min Thant <[email protected]>
Co-authored-by: Neelanjan Manna <[email protected]> Signed-off-by: Thiha Min Thant <[email protected]>
…#290 Signed-off-by: Thiha Min Thant <[email protected]>
thiha-min-thant
force-pushed
the
add-argo-instanceid-label-docs
branch
from
412e789
to
c165f0e
Compare
|
Thanks for the feedback, @neelanjan00 ! I've made the necessary updates based on your suggestions. |
Saranya-jena
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
workflows.argoproj.io/controller-instanceidlabel in the Workflow YAML.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #290Special notes for your reviewer:
Checklist:
documentationtag