Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme-vars.yml #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Droidem
Copy link

@Droidem Droidem commented Oct 10, 2024

changed the way to get speedtest servers.

linuxserver.io


  • [ x] I have read the contributing guideline and understand that I have made the correct modifications

Description:

Changes the way the user is able to get the closest servers.

Benefits of this PR and context:

#28 Not really outstanding but it does fix it. Currently it wants you to run a docker exec command under the docker that you are currently installing.

How Has This Been Tested?

Simply visiting the link brings up the servers.

Source / References:

changed the way to get SPEEDTEST_SERVERS
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@LinuxServer-CI
Copy link
Contributor

I am a bot, here are the test results for this PR:
https://ci-tests.linuxserver.io/lspipepr/speedtest-tracker/v0.21.4-pkg-e82afaf5-dev-b4d7c589670be235e134d9ea659721e929706282-pr-29/index.html
https://ci-tests.linuxserver.io/lspipepr/speedtest-tracker/v0.21.4-pkg-e82afaf5-dev-b4d7c589670be235e134d9ea659721e929706282-pr-29/shellcheck-result.xml

Tag Passed
amd64-v0.21.4-pkg-e82afaf5-dev-b4d7c589670be235e134d9ea659721e929706282-pr-29
arm64v8-v0.21.4-pkg-e82afaf5-dev-b4d7c589670be235e134d9ea659721e929706282-pr-29

@aptalca
Copy link
Member

aptalca commented Oct 10, 2024

Thanks for the PR, but the docker exec command returns servers close to the container host, whereas the web url returns servers close to the user's web browser. That's not very useful when the user is remote to the container host or if there are VPNs involved.

@edsai
Copy link

edsai commented Oct 14, 2024

Thanks for the PR, but the docker exec command returns servers close to the container host, whereas the web url returns servers close to the user's web browser. That's not very useful when the user is remote to the container host or if there are VPNs involved.

The docker exec command returns "/www/artisan app:ookla-list-servers
Error response from daemon: No such container: speedtest-tracker" if the container doesn't exist yet. This is a roadblock on platforms like unraid where the container doesn't exist until you complete the installation. You can't install the container without the filling out the required input field for servers. I had to get on another host, do a pull, and then run the command.

@drizuid
Copy link
Member

drizuid commented Oct 15, 2024

I had to get on another host, do a pull, and then run the command.

you could just open the cli on your unraid and do the same. the unraid ui just does docker run behind it.

@edsai
Copy link

edsai commented Oct 15, 2024

I had to get on another host, do a pull, and then run the command.

you could just open the cli on your unraid and do the same. the unraid ui just does docker run behind it.

Fair but it doesn't change the fact that the instructions in their current state have a blocker while trying to install and configure speedtest-tracker due to the fact that obtaining server id's requires the image to already be installed. Sounds like simple instructions of "Use this URL to find the servers closest to your client or pull the docker image and run the following command" would be a better solution.

@LinuxServer-CI
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants