-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme-vars.yml #29
base: main
Are you sure you want to change the base?
Conversation
changed the way to get SPEEDTEST_SERVERS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this pull request! Be sure to follow the pull request template!
I am a bot, here are the test results for this PR:
|
Thanks for the PR, but the docker exec command returns servers close to the container host, whereas the web url returns servers close to the user's web browser. That's not very useful when the user is remote to the container host or if there are VPNs involved. |
The docker exec command returns "/www/artisan app:ookla-list-servers |
you could just open the cli on your unraid and do the same. the unraid ui just does docker run behind it. |
Fair but it doesn't change the fact that the instructions in their current state have a blocker while trying to install and configure speedtest-tracker due to the fact that obtaining server id's requires the image to already be installed. Sounds like simple instructions of "Use this URL to find the servers closest to your client or pull the docker image and run the following command" would be a better solution. |
This pull request has been automatically marked as stale because it has not had recent activity. This might be due to missing feedback from OP. It will be closed if no further activity occurs. Thank you for your contributions. |
changed the way to get speedtest servers.
Description:
Changes the way the user is able to get the closest servers.
Benefits of this PR and context:
#28 Not really outstanding but it does fix it. Currently it wants you to run a docker exec command under the docker that you are currently installing.
How Has This Been Tested?
Simply visiting the link brings up the servers.
Source / References: