Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL2] DirectFB: fix DirectFB_SetTextureScaleMode() declaration (fixes gcc-14.x compile) #11544

Conversation

pseiderer
Copy link

Description

DirectFB: fix DirectFB_SetTextureScaleMode() declaration

Fixes:

     src/video/directfb/SDL_DirectFB_render.c: In function ‘DirectFB_CreateRenderer’:
     src/video/directfb/SDL_DirectFB_render.c:1153:35: error: assignment to ‘void (*)(SDL_Renderer *, SDL_Texture *, SDL_ScaleMode)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]
     1153 |     renderer->SetTextureScaleMode = DirectFB_SetTextureScaleMode;
          |                                   ^

Existing Issue(s)

Fixes:

  src/video/directfb/SDL_DirectFB_render.c: In function ‘DirectFB_CreateRenderer’:
  src/video/directfb/SDL_DirectFB_render.c:1153:35: error: assignment to ‘void (*)(SDL_Renderer *, SDL_Texture *, SDL_ScaleMode)’ from incompatible pointer type ‘void (*)(void)’ [-Wincompatible-pointer-types]
   1153 |     renderer->SetTextureScaleMode = DirectFB_SetTextureScaleMode;
        |                                   ^

Signed-off-by: Peter Seiderer <[email protected]>
---
Notes:
  - declaration was just recently changed by commit 'Fix warning for Android
    NDK compiler: "function declaration without a prototype is deprecated in
    all versions of C [-Wstrict-prototypes]"', see
    libsdl-org@ccade50
@slouken slouken merged commit b64540d into libsdl-org:SDL2 Nov 27, 2024
38 checks passed
@slouken
Copy link
Collaborator

slouken commented Nov 27, 2024

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants