Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: run tests on webkit for webRTC #1832

Closed
wants to merge 10 commits into from
Closed

test: run tests on webkit for webRTC #1832

wants to merge 10 commits into from

Conversation

maschad
Copy link
Member

@maschad maschad commented Jun 16, 2023

No description provided.

@maschad maschad requested a review from achingbrain June 16, 2023 16:18
@achingbrain achingbrain force-pushed the master branch 2 times, most recently from ea8a063 to d853d12 Compare June 19, 2023 11:23
@maschad maschad self-assigned this Jun 19, 2023
@maschad maschad marked this pull request as draft June 21, 2023 20:32
@maschad maschad marked this pull request as ready for review June 21, 2023 20:39
@maschad maschad requested a review from wemeetagain June 23, 2023 23:23
achingbrain
achingbrain requested changes Jun 26, 2023
View reviewed changes
packages/transport-webrtc/package.json Outdated Show resolved Hide resolved
packages/transport-webrtc/package.json Outdated Show resolved Hide resolved
packages/transport-webrtc/package.json Outdated Show resolved Hide resolved
packages/transport-webrtc/test/basics.spec.ts Outdated Show resolved Hide resolved
@maschad maschad marked this pull request as draft June 29, 2023 22:40
@maschad maschad marked this pull request as ready for review July 3, 2023 18:49
@maschad maschad requested a review from achingbrain July 3, 2023 18:49
achingbrain
achingbrain requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a test:webkit script added to the package.json in the monorepo root as well, otherwise the webkit tests will not be run.

@maschad maschad marked this pull request as draft July 4, 2023 14:48
@maschad
Copy link
Member Author

maschad commented Jul 4, 2023 •
edited
Loading

it seems on webkit that the RTCDataChannel doesn't send the arraybuffer binaryType the same way that other browsers do, which results in some failures when closing a connection, I a bit unsure how to proceed as the only way I have gotten this to work is to add a delay(10) or greater, which is obviously not a fix.

@maschad
Copy link
Member Author

maschad commented Aug 30, 2023

Currently blocked per libp2p/js-libp2p-webrtc#177 (comment)

@maschad
Copy link
Member Author

maschad commented Aug 30, 2023

Closing this until #2007 is resolved

@maschad maschad closed this Aug 30, 2023
@maschad maschad mentioned this pull request May 11, 2024
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain requested changes

@wemeetagain wemeetagain Awaiting requested review from wemeetagain

Assignees

@maschad maschad

Labels
None yet
Projects
js-libp2p
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maschad @achingbrain