tools: fix order of nuse_vif_netmap_init() Issue #15 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tools: fix dpdk build
tools: fix vif-netmap init issue of order
|
I believe your added line __define_initcall(nuse_vif_netmap_init, 1) is not related to the issue #15, though there are a couple of similar lines in other nuse-vif-* files. The original issue of #15 was fixed by reordering the .o files, which we don't need to use ___define_initcall for the same purpose. Did you see any improvement with this additional line ? |
|
@thehajime Well, I just checked it again and found it was my fault. Sorry for that. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Isuue #15 reported, ping or Iperf can not sending or receiving packets at this commit when vif type is NETMAP, this commit can fix this problem.