Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping of (non-fiction) books by identifier #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

john-fun
Copy link

@john-fun john-fun commented Feb 1, 2023

Changes:

  1. .gitignore added (for bin, obj, .vs and packages folders).
  2. .editorconfig modified to set the ident_size to 4 spaces (to force/match the indentation style used by the project).
  3. Added Identifier column in the non-fiction books search result tab. It displays the Identifier property of the Book object.
  4. Non-fiction books are grouped by the IdentifierPlain.

Issues:

  1. Should the changes (3. & 4.) be applied to fiction books too?
  2. Should the Identifier column be displayed or leave it hidden as before. Is it possible to show a context menu to select which columns to be visible?
  3. Translations of "Identifier" column name in different languages. Using Google Translate?
  4. Currently the "title" of the grouping is the group id. Anything better?
  5. Color of the border of the group. Currently is hard-coded to BorderBrush="#FF002255". How to make it to follow the color theme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant