Taking Codacy suggestions into account #16

[rajitha1998]

Fixes #16

Proposed Changes

• This PR adds some Codacy suggestions in order to improve code quality

[rajikaimal]

@rajitha1998 did you use Prettier to format?

[rajitha1998]

No, I haven't use prettier to format. Shall I format the code using Prettier ? @rajikaimal

• By the way some suggestions under the category of Error Prone which I assume that the console logs were added to display the output of this example or to display an error message. So I didn't remove them.
  E.g. -
  

• I also assumed that the security issue by using a Found non-literal argument in require in this scenario should be ignored const ncConfig = require(path.join(process.cwd(), ".nc.config"));
  

[rajikaimal]

@rajitha1998 Yes, use Prettier to format all the files.

[rajitha1998]

@rajikaimal , I formatted the code using prettier. Since codacy was showing me the below suggestion I had to add a prettier rule for that in the .prettierrc file as { "arrowParens": "always" }

// Bad 
a => {
}
// Good 
(a) => {
}

Related links -

• https://prettier.io/docs/en/options.html
• Parentheses around single parameter arrow functions / Add support for arrow-parens property prettier/prettier#812
• Simple arrow function parens option prettier/prettier#3324

[rajikaimal]

@rajitha1998 Can you resolve the conflict. LGTM

[rajitha1998]

@rajitha1998 Can you resolve the conflict. LGTM

sure

[rajitha1998]

Merge conflicts fixed @rajikaimal ☺️