Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile,Desktop: Upgrade CodeMirror packages #11221

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Mobile,Desktop: Upgrade CodeMirror packages #11221

wants to merge 1 commit into from

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Oct 16, 2024 •
edited
Loading

Summary

This pull request upgrades most @codemirror/ packages. This is similar to #11034.

To prevent regressions caused by the last upgrade attempt, this pull request also disables CodeMirror's use of the EditContext API.

Testing plan

Android 13:

  1. Open a note in edit mode.
  2. Move the cursor to the end of the note.
  3. With the SwiftKey keyboard, swipe to type 2-3 words.
  4. Verify that the words are added to the editor.
  5. Tap on the cursor once and click "select all".
  6. Verify that all content in the editor is selected.

@personalizedrefrigerator
Mobile,Desktop: Upgrade CodeMirror packages
b1c1a77 
This commit upgrades most `@codemirror/` packages, like
laurent22#11034, but disables the
EditContext API (see laurent22#11170).
@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@personalizedrefrigerator