Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Fixes #10560: Fix table column and rows not being resizable on RTE #11037

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

pedr
Copy link
Collaborator

@pedr pedr commented Sep 13, 2024

Fixes #10560
Related to Desktop: Fixes #10562: Preserve table customization made on RTE

Summary

This property was set to be disabled. I'm not sure exactly why without this property sometimes it was possible to change the column/rows, but with this change, it seems to be always possible.

On the other PR related to changes made to the RTE table I also added some additional logic to preserve the table if its style property for width or height are different. I think this code looks a little ugly:
a396446

The problem is that the only way to know if the table was resized is to check its columns and rows and compare the values between them, but it seems like it could be problematic

Testing

I couldn't think of a way of adding automated testing to this change.

But a way to reproduce the previous behavior is to:

  • Switch to RTE
  • Create a new note
  • Create a table 2x2
  • Write "a" in the top left corner
  • Switch to Markdown
  • Switch to RTE
  • Before this PR, it shouldn't be possible to resize columns or rows, now it is

@pedr pedr requested a review from laurent22 September 13, 2024 01:08
@laurent22
Copy link
Owner

Thanks for fixing this. Maybe table_resize_bars was set to false because we didn't support this before

@laurent22 laurent22 merged commit 8d3ac63 into laurent22:dev Sep 13, 2024
10 checks passed
@pedr pedr deleted the fix-not-able-to-resize-table branch September 13, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table column size can't be changed in RTE
2 participants