Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "Unexpected X" error in 5.3 #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

psaunders
Copy link

In prior versions of Laravel, when registering custom Blade directives using the directive method, the $expression passed to your directive callback contained the outer-most parenthesis. In Laravel 5.3, these outer-most parenthesis are not included in the expression passed to your directive callback.

@laracasts
Copy link
Collaborator

But this now means that 5.3 is the minimum requirement, right?

@psaunders
Copy link
Author

psaunders commented Sep 12, 2016

Yes. It'd have to be a new tag/version. Alternatively the readme could be amended to have an aside for 5.3

 "If >= 5.3 @cache(($thing))" 

Or there could be a parenthesis/version check in MatryoshkaServiceProvider. I'll leave it to you, let me know if you want one of those in the PR.

This has been a handy package BTW.

@willvincent
Copy link

Fixed to add support to 5.3, without removing support for 5.2 in PR #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants