Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve scrolling issue in workflow-log table #11302

Merged

Conversation

DDDDD12138
Copy link
Contributor

Summary

On the workflow-log page, when the page size (limit) is set to a large value that exceeds one page, the table should display a scrollbar to prevent the paginator from being pushed out of view.

This PR addresses the issue by adding a maximum height to the workflow-log table wrapper, enabling scrolling.

Screenshots

Before: After:
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 3, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 3, 2024
@crazywoola crazywoola merged commit 1cb5a12 into langgenius:main Dec 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants