Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: improve dropdownComponent test #4855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor: improve dropdownComponent test #4855

wants to merge 1 commit into from
+9 −4

Conversation

anovazzi1
Copy link
Contributor

this pull request improves dropdownComponent test performance

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Nov 26, 2024
Cristhianzl
Cristhianzl approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Cristhianzl Cristhianzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 26, 2024
@anovazzi1 anovazzi1 enabled auto-merge (squash) November 27, 2024 13:01
@ogabrielluiz ogabrielluiz changed the title Refactor: improve dropdownComponent Refactor: improve dropdownComponent test Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cristhianzl Cristhianzl Cristhianzl approved these changes

@ogabrielluiz ogabrielluiz ogabrielluiz approved these changes

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anovazzi1 @ogabrielluiz @Cristhianzl