fix bug causing sidebar ender to not merge correctly

lando · Nov 4, 2024 · 1f40427 · 1f40427
1 parent 7a3b1a2
commit 1f40427
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## {{ UNRELEASED_VERSION }} - [{{ UNRELEASED_DATE }}]({{ UNRELEASED_LINK }})
 
 * Fixed bug in `normalize-mvb` causing `multiVersionBuild.build` to sometimes not be set correctly
+* Fixed `lando` configset bug causing `sidebarEnder` to not merge correctly
 
 ## v1.1.0-beta.17 - [November 1, 2024](https://github.com/lando/vitepress-theme-default-plus/releases/tag/v1.1.0-beta.17)
 

diff --git a/config/landov3.js b/config/landov3.js
@@ -30,7 +30,7 @@ export default function({
   const repo = landoPlugin ? `https://github.com/lando/${landoPlugin}` : 'https://github.com/lando';
 
   // if no sidebar ender and we have plugin/version then do it
-  if (!themeConfig.sidebarEnder && landoPlugin && version) {
+  if (!themeConfig.sidebarEnder && themeConfig.sidebarEnder !== false && landoPlugin && version) {
     themeConfig.sidebarEnder = {
       text,
       collapsed: true,

diff --git a/config/landov4.js b/config/landov4.js
@@ -31,7 +31,7 @@ export default function({
   const repo = landoPlugin ? `https://github.com/lando/${landoPlugin}` : 'https://github.com/lando';
 
   // if no sidebar ender and we have plugin/version then do it
-  if (!themeConfig.sidebarEnder && landoPlugin && version) {
+  if (!themeConfig.sidebarEnder && themeConfig.sidebarEnder !== false && landoPlugin && version) {
     themeConfig.sidebarEnder = {
       text,
       collapsed: true,