fixes #2 SimpleStreamResponseSender::sendStream if content-length was provided

[marc-mabe]

Q	A
Documentation	no
Bugfix	yes
BC Break	yes
New Feature	no
RFC	no
QA	no

Description

see #2 and zendframework/zend-mvc#315

[Xerkus]

This emitter is dangerously brittle. Result would be drastically different if say some listener read from the stream and/or did a rewind. Or if $request->getBody() was used.
Ideally this emitter should rewind stream if seekable and then output stream content. That won't match Laminas\Http\Response\Stream::readStream() behavior used to populate body on $request->getBody() call.

This change of behavior would not be backwards compatible and since existing behavior was around for years I am cautious of accepting this change.

I am going to label this bug as won't fix and ask you to provide feature request instead with new stream response sender.

[marc-mabe]

Hi @Xerkus,

I do agree this is a breaking change but the problem that I'm facing is that currently it's simply not possible to respond a content range without copying this content range (using Range/Content-Range headers).

For my use-case of fetching big video files from S3 this is a no-go as either I have to copy the full range into memory or on disk ... in both cases I loose performance and get the risk of OOM/Disk-Space errors.

Ideally the user should should define the stream to be send - including the start position (e.g. by seeking to the exact position) and optionally defining the length but the MVC framework should no make any objections of what should be send.