Add team attribute to entities #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also closes #960 |
tvillegas98
previously approved these changes
Nov 25, 2024
| character_name: character_name, | ||
| name: player_name, | ||
| from_pid: from_pid, | ||
| type: :human |
There was a problem hiding this comment.
Is there a reason for this type parameter? just wondering
There was a problem hiding this comment.
It's used by the game_updater genserver to save human and bot ids in different lists.
See game_updater.ex:80-84
tvillegas98
previously approved these changes
Dec 3, 2024
manucamejo
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Hey @Nico-Sanchez I'm getting an error when the match ends in Deathmatch mode.
** (BadMapError) expected a map, got: 12
(elixir 1.16.2) lib/map.ex:682: Map.update(12, :category, nil, #Function<8.2673582/1 in Arena.GameUpdater.complete_entity/2>)
(arena 0.11.1) lib/arena/game_updater.ex:812: Arena.GameUpdater.complete_entity/2
(arena 0.11.1) lib/arena/game_updater.ex:803: anonymous fn/3 in Arena.GameUpdater.complete_entities/2
(stdlib 5.2.1) maps.erl:416: :maps.fold_1/4
(arena 0.11.1) lib/arena/game_updater.ex:786: Arena.GameUpdater.broadcast_game_ended/2
(arena 0.11.1) lib/arena/game_updater.ex:353: Arena.GameUpdater.handle_info/2
(stdlib 5.2.1) gen_server.erl:1095: :gen_server.try_handle_info/3
(stdlib 5.2.1) gen_server.erl:1183: :gen_server.handle_msg/6
(stdlib 5.2.1) proc_lib.erl:241: :proc_lib.init_p_do_apply/3
Last message: :deathmatch_end_game_checkCan you solve it?
manucamejo
approved these changes
Dec 9, 2024
tvillegas98
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Merge alongside https://github.com/lambdaclass/champions_of_mirra/pull/2245
Motivation
We need a new team game mode.
Summary of changes
How to test it?
Play the game with the front branch. Everything should work as usual.
Pay special attention to collisions, damage, effects, pools, projectiles, etc. Everything should affect the proper entities.
Checklist