Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-497] Add Upgrade config import #700

Closed
wants to merge 2 commits into from

Conversation

lotuuu
Copy link
Contributor

@lotuuu lotuuu commented Jun 12, 2024

Motivation

Adds configuration for Upgrades and their dependencies. They have been made in two different files because it's easier for development. It also seems like the tidier way to do it, since otherwise it could become kind of messy and difficult to track.
Closes lambdaclass/afk_gacha_game#497

Summary of changes

  • Add upgrades.json and upgrade_dependencies.json.
  • Add import functions for them.
  • Tidy up the Config module that was needing some love.
    • Move all private functions to the end of the module.
    • Add doc to missing functions.
  • Remove wrong fields in Buffs

How to test it?

  • Run the app and check that everything runs normally.
  • Tests too.
  • Go through the steps in [GH-428] Implement Buffs for Dungeon #632 and check that everything still works.
  • Inspect the uploaded data (upgrades, buffs, dependencies) and check that everything is there.

@lotuuu lotuuu changed the title Add Upgrade config import [GH-497] Add Upgrade config import Jun 12, 2024
@lotuuu lotuuu self-assigned this Jun 12, 2024
@lotuuu lotuuu added the autobattler AFK Gacha Autobattler game label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autobattler AFK Gacha Autobattler game freeze
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CONFIG] Implement Upgrades config
3 participants