Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-399] Deal damage over time #662
[GH-399] Deal damage over time #662
Changes from all commits
8c20a5f
e7dc796
7b7e93e
100a739
8b86536
2c83739
3c66ab9
2ed4298
f3e8cc6
0659b5a
915b70c
80927e2
e21dce7
930cd8d
8142ce9
69ba52f
24862e8
ef92bb8
38d7a97
3d12b61
2a34bc7
8e5d064
8718b8e
1def3b3
4c02dc0
dce506b
82416c4
d755b7c
11c3ad3
a5a24ea
fdafe26
4313ec6
1b4e2c3
beab235
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a really, really edge-y edge case here where this fails still. Do you think we should add an issue to revisit this later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, the case in which two units of the same character apply the same EoT to a target would be handled by this comparison because the execution over time would have different values in the
caster
field.