Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-994] - Deathmatch Improvements #1001

Merged
merged 13 commits into from
Dec 10, 2024
Merged

[GH-994] - Deathmatch Improvements #1001

merged 13 commits into from
Dec 10, 2024

Conversation

tvillegas98
Copy link
Contributor

@tvillegas98 tvillegas98 commented Dec 5, 2024 •
edited
Loading

Motivation

Fix some a few concerns of the deathmatch mode
Addresses part of #994

Summary of changes

How to test it?

  • See the changes above and play a deathmatch move

Checklist

  • Tested the changes locally.
  • Reviewed the changes on GitHub, line by line.
  • This change requires new documentation.
    • Documentation has been added/updated.

@tvillegas98
feat: respawn issues
17a4511 
- set power ups to 0 when respawning
- restore to the base health when respawning
- clear all the effects when respawning
- add the invencibility effect for three seconds when respawning
@tvillegas98
fix: players positions were being applied after every kill
e47a181
@tvillegas98
chore: mix format
52566d7
@tvillegas98 tvillegas98 marked this pull request as ready for review December 5, 2024 14:57
manucamejo
manucamejo previously approved these changes Dec 9, 2024
View reviewed changes
@manucamejo manucamejo merged commit ec19b3f into main Dec 10, 2024
1 check passed
@manucamejo manucamejo deleted the gh-994-deathmatch-improvements branch December 10, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nico-Sanchez Nico-Sanchez Nico-Sanchez approved these changes

@manucamejo manucamejo manucamejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tvillegas98 @manucamejo @Nico-Sanchez