Add setattr and fix getattr to PyTypeId struct #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructs inside structs
Juan-M-V
approved these changes
Oct 31, 2022
juanbono
approved these changes
Oct 31, 2022
pefontana
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for assigning PyTypeIds fields. This is useful when assigning struct fields inside a hint.
It also corrects the
__getattr__method.With this fixes, the following tests run:
Note: If a field inside a struct is another struct and we want to assign a struct there, it would fail. It is not clear at the moment if this should be supported. See issue #86.