Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-482] Change "helmet" to "amulet" type in unit detail scene #490

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GH-482] Change "helmet" to "amulet" type in unit detail scene #490

wants to merge 1 commit into from

Conversation

lotuuu
Copy link
Collaborator

@lotuuu lotuuu commented Jun 11, 2024 •
edited
Loading

Closes #482

Motivation

We changed helmets for amulets in our backend.

Summary of changes

  • Change "helmet" to "amulet" in the "Equipment Type" serialized field of the upper-left slot.

How has this been tested?

Amulets should appear when you check the upper-left item slot of a unit in the Barracks.

Checklist

  • I have tested the changes locally.
  • I self-reviewed the changes on GitHub, line by line.
  • Tests have been added/updated.
  • This change requires new documentation.
    • Documentation has been added/updated.
  • I have tested the changes in another devices.
    • Tested in iOS.
    • Tested in Android.

@lotuuu lotuuu changed the title Change "helmet" to "amulet" type in unit detail scene [GH-482] Change "helmet" to "amulet" type in unit detail scene Jun 11, 2024
@lotuuu lotuuu self-assigned this Jun 11, 2024
ncontinanza
ncontinanza approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@ncontinanza ncontinanza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncontinanza ncontinanza ncontinanza approved these changes

@AminArria AminArria Awaiting requested review from AminArria AminArria is a code owner

@manucamejo manucamejo Awaiting requested review from manucamejo manucamejo is a code owner

@tvillegas98 tvillegas98 Awaiting requested review from tvillegas98 tvillegas98 is a code owner

@martinacantaro martinacantaro Awaiting requested review from martinacantaro martinacantaro is a code owner

@mgrunwaldt mgrunwaldt Awaiting requested review from mgrunwaldt

@saugon saugon Awaiting requested review from saugon saugon is a code owner

@marco-paulucci marco-paulucci Awaiting requested review from marco-paulucci marco-paulucci is a code owner

@agustinesco agustinesco Awaiting requested review from agustinesco agustinesco is a code owner

@tkz00 tkz00 Awaiting requested review from tkz00 tkz00 is a code owner

@Nico-Sanchez Nico-Sanchez Awaiting requested review from Nico-Sanchez Nico-Sanchez is a code owner

@AngieDutra AngieDutra Awaiting requested review from AngieDutra AngieDutra is a code owner

@alfopisano alfopisano Awaiting requested review from alfopisano alfopisano is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

@lotuuu lotuuu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix inventory and item equipping in the client
2 participants
@lotuuu @ncontinanza