-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-437] Claim dungeon AFK Rewards #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make the claim happen on Dungeon scene instead of DungeonSettlementScene. The idea is that it will look like it is seamlessly applying your rewards every 20 minutes or so, while not needing a job to trigger every said amount of time. Instead, when we would display the currency to the user, we first calculate all the accumulated rewards.
Also, if we could add the supplies to the header as related currency there that'd be great and really tie all this functionality together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!!
Closes #437
Motivation
We need to claim the AFK rewards every time the user goes to the Dungeon Settlement
Summary of changes
How has this been tested?
apps/champions/priv/dungeon_settlement_levels.json
and increase the amount of afk supplies provided by the first Dungeon level. Changing it to 1440 will give you 1 supply per minute, and you won't need to wait that long to test this behaviour.{:ok, user} = Champions.Users.get_user(user_id)
and thenuser.currencies
to see the available currencies.You'll notice that if you come back and forth from that scene during the waiting time, you won't receive any rewards despite how long you wait. We'll address this problem in this issue: #491
Test additions / changes
List tests added/updated.
Checklist